Comments on: Simple backup script for Ubuntu http://marianoiglesias.com.ar/ubuntu/simple-backup-script-for-ubuntu/ A glimpse at a coder's troubled mind Wed, 30 Jun 2010 11:12:52 +0000 hourly 1 http://wordpress.org/?v=3.0.1 By: Dieter_be [Visitor] http://marianoiglesias.com.ar/ubuntu/simple-backup-script-for-ubuntu/comment-page-1/#comment-53 Dieter_be [Visitor] Sat, 28 Jun 2008 10:01:00 +0000 http://marianoiglesias.com.ar/1/simple-backup-script-for-ubuntu/#comment-53 Hi, here are some tips for you.<br /> You can use other delimiters then '/' in sed. So that if you plan to use slashes in your regex, you don't need to escape them. I usually delimit with '#' in this case.<br /> So the command to strip trailing slashes becomes this : sed 's#/$##'<br /> Note that '-e' is not needed, it's the default for sed. Also you don't need the 'g' pattern modifier.<br /> Knowing this, you can make your regexes a lot easier ;-)<br /> <br /> Also check 'man test', you'll see that you can rewrite [ "$1" != "" ] into [ -n "$1" ]<br /> <br /> You don't need to echo "" for a newline, just echo without args, or add "\n" in your previous echo and use the -e flag.<br /> <br /> Also you might want to redirect your error messages to stderr.<br /> <br /> There is more stuff that can be improved... I suggest you go check out the bash tutorials at tldp.org. they are pretty good ;-) Hi, here are some tips for you.
You can use other delimiters then ‘/’ in sed. So that if you plan to use slashes in your regex, you don’t need to escape them. I usually delimit with ‘#’ in this case.
So the command to strip trailing slashes becomes this : sed ‘s#/$##’
Note that ‘-e’ is not needed, it’s the default for sed. Also you don’t need the ‘g’ pattern modifier.
Knowing this, you can make your regexes a lot easier ;-)

Also check ‘man test’, you’ll see that you can rewrite [ "$1" != "" ] into [ -n "$1" ]

You don’t need to echo “” for a newline, just echo without args, or add “\n” in your previous echo and use the -e flag.

Also you might want to redirect your error messages to stderr.

There is more stuff that can be improved… I suggest you go check out the bash tutorials at tldp.org. they are pretty good ;-)

]]>